Print warning if traces merging from sfn to sfn is skipped #1447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Let's say Step Function A executes Step Function B. If B:
Parameters
field, orParameters.Input
field is not a JSON objectParameters.Input
field has a customCONTEXT.$
fieldtraces merging will be skipped, but no warning message will be printed.
What
Print a warning message in these cases to let users know what won't work.
Testing
1. Missing Parameters field
I wasn't able to test this because
Parameters
field is required when editing the State Machine from AWS Management Console.2.
Parameters.Input
field is not a JSON objectSteps
datadog-ci stepfunctions instrument
commandResult
A warning message is printed as expected:
3. custom
CONTEXT.$
4. Happy case
datadog-ci stepfunctions instrument
finishes with no errorReview checklist